Update spring gem for Rails 7 #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
approved these changes
Nov 15, 2023
We needed to go from v2 to at least v3.0.0 as per: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0-spring Removing `spring-watcher-listen` was the easy way to do this. If that's an important part of people's workflow then they can figure out how to make it work. (I note from https://github.com/rails/spring-watcher-listen that there may be issues running spring-watcher-listen with ARM Macs.)
yndajas
force-pushed
the
update-spring-for-rails7
branch
from
ab067da
to
90e1c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to go from v2 to at least v3.0.0 as per:
https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-6-1-to-rails-7-0-spring
Removing
spring-watcher-listenwas the easy way to do this. If that's an important part of people's workflow then they can figure out how to make it work. (I note from https://github.com/rails/spring-watcher-listen that there may be issues running spring-watcher-listen with ARM Macs.)