Skip to content

Commit

Permalink
fix: package node modules (#248)
Browse files Browse the repository at this point in the history
semantic-release is smart enough to know to **not** pack any node
modules, so we have to purposefully override via `.npmignore`

However, i accidentally created.... version 3.16. We'll need
@BrendanChou to remove it
https://www.npmjs.com/package/@dydxprotocol/v4-client-js?activeTab=versions
(sorry 🙇 )

---------

Co-authored-by: github_actions <[email protected]>
  • Loading branch information
yogurtandjam and dydx-ci committed Sep 19, 2024
1 parent d16a96b commit 10cef7a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/js-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ jobs:
- name: Run semantic-release
run: npm run release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_WRITE }}


1 change: 1 addition & 0 deletions v4-client-js/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!build/node_modules/@dydxprotocol/v4-proto/**/**.ts
2 changes: 1 addition & 1 deletion v4-client-js/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 10cef7a

Please sign in to comment.