Skip to content

Commit

Permalink
Remove broken python client (#124)
Browse files Browse the repository at this point in the history
* Remove broken python client

* Remove reference to Python client
  • Loading branch information
adamfraser authored Feb 28, 2024
1 parent fd1e9d3 commit 37f6ed1
Show file tree
Hide file tree
Showing 139 changed files with 0 additions and 11,890 deletions.
Binary file added .DS_Store
Binary file not shown.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
## v4-client-js
The dYdX Chain Client Typescript client is used for placing transactions and querying the dYdX chain.

## v4-client-py
Python client for dYdX Chain.

The library is currently tested against Python versions 3.9, and 3.11.

# Third-party Clients

[C++ Client](https://github.com/asnefedovv/dydx-v4-client-cpp)
Expand Down
132 changes: 0 additions & 132 deletions v4-client-py/.gitignore

This file was deleted.

19 changes: 0 additions & 19 deletions v4-client-py/.gitleaks.toml

This file was deleted.

Empty file removed v4-client-py/.gitleaksignore
Empty file.
17 changes: 0 additions & 17 deletions v4-client-py/.vscode/launch.json

This file was deleted.

5 changes: 0 additions & 5 deletions v4-client-py/.vscode/settings.json

This file was deleted.

Loading

2 comments on commit 37f6ed1

@andredesouza1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi is the python client currently unusable? Been struggling with some issues and just noticed this.

@jorenham
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say that this "if it's broken, delete each and every trace of it" mentality sits well with me.
And suddenly deleting the entire PyPI package is a big no-no.
As far as I could tell, there wasn't even as much as a deprecation notice...

What was broken exactly? Were there critical security flaws?

And what should all of us that depend on this package do now?

Please sign in to comment.