Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination clients support #159

Merged
merged 9 commits into from
Jun 3, 2024
Merged

feat: add pagination clients support #159

merged 9 commits into from
Jun 3, 2024

Conversation

DavideSegullo
Copy link
Contributor

@DavideSegullo DavideSegullo commented May 22, 2024 •
edited
Loading

This PR exposes both in the JS and Python client the parameters to be able to use pagination

@DavideSegullo DavideSegullo requested a review from a team as a code owner May 28, 2024 16:06
rosepuppy
rosepuppy reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@rosepuppy rosepuppy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm! We require the v4-client-js npm version to be bumped manually for the change to be reflected, so just need to bump the version.

@DavideSegullo
Copy link
Contributor Author

Change lgtm! We require the v4-client-js npm version to be bumped manually for the change to be reflected, so just need to bump the version.

Done!

@rosepuppy
Copy link
Contributor

@DavideSegullo not sure why the python tests are failing. I don't think we are maintaining the python client anymore. I think you can remove those changes if you don't need it for now.

@DavideSegullo
Copy link
Contributor Author

@DavideSegullo not sure why the python tests are failing. I don't think we are maintaining the python client anymore. I think you can remove those changes if you don't need it for now.

Yep, I'll revert it

@DavideSegullo
Copy link
Contributor Author

@rosepuppy Done!

@rosepuppy rosepuppy merged commit 484ff81 into dydxprotocol:main Jun 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dydxwill dydxwill dydxwill approved these changes

@rosepuppy rosepuppy rosepuppy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavideSegullo @rosepuppy @dydxwill