Update websocket.py #186
Closed
Update websocket.py #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piwonskp
approved these changes
Jun 24, 2024
Fix invalid subscription ID for candles channel
nodje1z
force-pushed
the
fix/candles-subscription-id
branch
from
f128dd0
to
169ebd5
Compare
dydxwill
approved these changes
Jul 1, 2024
Merged
|
Closing in favor of #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the invalid subscription ID for the
v4_candleschannel in thedydx_v4_clientlibrary.subscribeandunsubscribemethods in theCandlesclass to ensure theresolutionis converted to its string value before being included in the subscription ID.v4_candleschannel.Please review the changes and merge them into the main branch.