chore: Update v2 docs #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtin0x
force-pushed
the
samtin0x/update-v2-docs
branch
from
6696d08
to
d6fac07
Compare
| rest_indexer=REST_URL, | ||
| websocket_indexer=WEBSOCKET_URL | ||
| node_url="dydx-ops-grpc.kingnodes.com:443", # No 'https://' prefix | ||
| rest_indexer="https://indexer.v4.dydx.exchange", |
There was a problem hiding this comment.
@Christopher-Li are we okay with suggesting indexer endpoints via docs? if so this looks like a pretty solid upgrade from our current documentation
There was a problem hiding this comment.
@samtin0x i'd prefer if we keep these listed as variable names and instead link to https://docs.dydx.exchange/infrastructure_providers-network/resources#indexer-endpoints.
This will make the docs more durable to changes in indexer endpoints and also let developers know that they can set up their own indexer or node urls
samtin0x
force-pushed
the
samtin0x/update-v2-docs
branch
from
4a86d15
to
eb2de48
Compare
samtin0x
force-pushed
the
samtin0x/update-v2-docs
branch
from
eb2de48
to
3bfd0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.