feat: skip submit method for cctp withdrawals [OTE-640] #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
submitToSkipAPImethod on nobleclient.converts
cctpMultiMsgWithdrawto usesubmitToSkipAPIinstead of customsendmethod.Tested by performing a successful withdrawal to avalanche USDC and confirming that we used skip's
submitendpoint.This will ensure that all CCTP withdrawals are either auto-sweepable back into a user's dydx wallet or tracked by skip without relying on their auto-tracking polling logic.
Technically this method doesn't need to/shouldn't live here but it feels like overkill to create a
skipClientwhen we don't have a timeline for cutting over other paths to use the skip API.