fix: duplicate v4-proto dep into devDep #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogurtandjam
approved these changes
Sep 18, 2024
|
hmm i thought peerDependnecies also installed packages but looks like it doesnt 😢 |
moo-onthelawn
added a commit
that referenced
this pull request
Sep 18, 2024
Forgot to update package lock 😢 sorry my bad in #245. Minorly surprised that nothing broke tho 🤔 Usually when I forget this in v4-web I think I am prevented from pushing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into an issue where everytime I tried to commit with an updated v4-clients, I got
Cannot find module '@dydxprotocol/v4-proto/...Figured out from here that this is expected from moving proto into peerDependencies. Managed to get things working (using jeremy's nifty lil local install script) by duplicating into
devDependencieswhich I think should be adequate (as opposed to moving it intodependenciesbut someone lmk if I'm wrong