Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add construct orderbook example using websocket #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2hyunbin
Copy link

** I send a new PR to reflect a latest commit **

@yogurtandjam Thank you for applying the convention to the PR title.
Your feedback that the code should be encapsulated to make it easier to read is reasonable.
So I reflected the feedback.
Please let me know if there is anything else that needs to be improved!

  • When pushing orderbook data, it's better to insert it in the right place to keep the sorted orderbook list than to sort it at the end, but I chose a good read logic because the orderbook list is small and just an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant