address comment

dydxprotocol · Nov 8, 2023 · 2fe014b · 2fe014b
1 parent db1e93f
commit 2fe014b
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/OrderDetails/dydxOrderDetailsViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/OrderDetails/dydxOrderDetailsViewBuilder.swift
@@ -138,16 +138,18 @@ private class dydxOrderDetailsViewPresenter: HostedViewPresenter<dydxOrderDetail
             } else {
                 itemValue = .none
             }
-            return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.GENERAL.CREATED_AT"),
-                                                  value: itemValue)
+            return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.GENERAL.CREATED_AT"), value: itemValue)
         }
 
         var goodTil: dydxOrderDetailsViewModel.Item? {
-            if order.timeInForce == .gtt,
-               let expiresAtMilliseconds = order.expiresAtMilliseconds?.doubleValue {
-                let text = dydxFormatter.shared.dateAndTime(date: Date(milliseconds: expiresAtMilliseconds))
-                return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.TRADE.GOOD_TIL_TIME"),
-                                                      value: .string(text))
+            if order.timeInForce == .gtt {
+                let itemValue: dydxOrderDetailsViewModel.Item.ItemValue?
+                if let createdAtMilliseconds = order.expiresAtMilliseconds?.doubleValue {
+                    itemValue = .string(dydxFormatter.shared.dateAndTime(date: Date(milliseconds: createdAtMilliseconds)))
+                } else {
+                    itemValue = .none
+                }
+                return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.TRADE.GOOD_TIL_TIME"), value: itemValue)
             }
             return nil
         }