Skip to content

Commit

Permalink
Fix layout with Japanese and other languages (#256)
Browse files Browse the repository at this point in the history
* Fix filter layout with Japanese

* More fixes

* One more
  • Loading branch information
ruixhuang authored Sep 20, 2024
1 parent ec99284 commit 6ab0e84
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion PlatformUI/PlatformUI/Components/Input/PlatformInput.swift
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,6 @@ open class PlatformBooleanInputViewModel: PlatformValueInputViewModel {
return AnyView(
HStack(spacing: 0) {
self.header.createView(parentStyle: style)
.fixedSize()
Spacer()
Toggle("", isOn: self.inputBinding)
.toggleStyle(SwitchToggleStyle(tint: ThemeColor.SemanticColor.colorPurple.color))
Expand Down
1 change: 0 additions & 1 deletion PlatformUI/PlatformUI/Components/TabGroup/TabGroup.swift
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ private struct TabGroupView<ItemContent: PlatformViewModeling>: View {
}
}
}
.fixedSize(horizontal: false, vertical: true)
.animation(selectionAnimation, value: model.currentSelection)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public class FieldInputSwitchViewModel: FieldInputBaseViewModel {
.themeFont(fontSize: .small)
}
}
.fixedSize()
Spacer()
Toggle("", isOn: self.inputBinding)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ public class dydxMarketPositionViewModel: PlatformViewModel {
HStack(alignment: .top, spacing: 12) {
ForEach(views.indices, id: \.self) { index in
views[index]
.fixedSize(horizontal: true, vertical: false)
.padding(.vertical, 8)
if index < views.count - 1 {
DividerModel().createView()
Expand All @@ -167,7 +166,6 @@ public class dydxMarketPositionViewModel: PlatformViewModel {
ForEach(views.indices, id: \.self) { index in
Spacer()
views[index]
.fixedSize(horizontal: true, vertical: false)
.padding(.vertical, 8)
Spacer()
if index < views.count - 1 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public class dydxTradeInputViewModel: PlatformViewModel {
.topAligned()
}
self.editViewModel?.createView(parentStyle: style)
.frame(width: self.isOrderbookCollapsed ? fullWidth: editViewWidth)
.frame(width: self.isOrderbookCollapsed ? fullWidth : editViewWidth)
}

VStack(spacing: -8) {
Expand Down

0 comments on commit 6ab0e84

Please sign in to comment.