Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRCL-3160] Load app scheme from env.json and add scripts to update the info.plist #10

Merged
merged 4 commits into from
Nov 8, 2023
Merged

[TRCL-3160] Load app scheme from env.json and add scripts to update the info.plist #10

merged 4 commits into from
Nov 8, 2023

Conversation

ruixhuang
Copy link
Contributor


Description / Intuition

Load app scheme configured in env.json in two ways:

  1. During build time, run set_scheme.sh to update the scheme in info.plist from remote env.json stored in the deployment URL specified in credentials.json.
  2. During run time, the app scheme in the code will be loaded from Abacus (which also comes from the env.json of the deployment URL).

Also bumped Abacus and the linter fixed a number of formatting issues.


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@linear Linear
Copy link

linear bot commented Nov 7, 2023

TRCL-3160 Set app scheme from env.json

johnqh
johnqh previously approved these changes Nov 7, 2023
View reviewed changes
@johnqh johnqh self-requested a review November 8, 2023 00:20
@johnqh johnqh merged commit 96e49d3 into main Nov 8, 2023
2 checks passed
@mike-dydx mike-dydx added this to the v1.0.0 milestone Nov 10, 2023
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
@johnqh @mike-dydx
Merge pull request #10 from dydxprotocol/features/app_scheme
31ce344 
[TRCL-3160] Load app scheme from env.json and add scripts to update the info.plist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnqh johnqh johnqh approved these changes

@mike-dydx mike-dydx Awaiting requested review from mike-dydx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruixhuang @johnqh @mike-dydx