trcl 2408 show good til and created at in ios app #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/trcl-2408-show-good-til-and-created-at-in-ios-app
branch
from
57d9cff
to
db1e93f
Compare
johnqh
reviewed
Nov 7, 2023
| let text = dydxFormatter.shared.interval(time: Date(milliseconds: expiresAtMilliseconds)) | ||
| return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.TRADE.GOOD_TIL"), | ||
| let text = dydxFormatter.shared.dateAndTime(date: Date(milliseconds: expiresAtMilliseconds)) | ||
| return dydxOrderDetailsViewModel.Item(title: DataLocalizer.localize(path: "APP.TRADE.GOOD_TIL_TIME"), | ||
| value: .string(text)) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
I think it should be .none, same as timePlaced, so it shows a "-".
Web shows a "-" right now, and Yi mentioned it should be a "-" on Slack. I just modified the ticket description to reflect that.
johnqh
approved these changes
Nov 8, 2023
mike-dydx
deleted the
mike/trcl-2408-show-good-til-and-created-at-in-ios-app
branch
mike-dydx
pushed a commit
that referenced
this pull request
Aug 21, 2024
…-and-created-at-in-ios-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-2408 : Show "good Til" and "created At" in iOS app
Description / Intuition
screenshots provided for long term orders (open)
Before/After Screenshots or Videos
Type of Change