Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CryptoSwift Pod #13

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Remove CryptoSwift Pod #13

merged 4 commits into from
Nov 10, 2023

Conversation

ruixhuang
Copy link
Contributor

@ruixhuang ruixhuang commented Nov 8, 2023


Description / Intuition

It's causing conflicts with the SPM version.


Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

johnqh
johnqh previously approved these changes Nov 8, 2023
@ruixhuang ruixhuang changed the title Renove CryptoSwift Pod Remove CryptoSwift Pod Nov 8, 2023
# Conflicts:
#	dydx/Pods/Pods.xcodeproj/project.pbxproj
@johnqh johnqh self-requested a review November 10, 2023 18:55
@johnqh johnqh merged commit d4d164d into main Nov 10, 2023
2 checks passed
@johnqh johnqh deleted the features/remove_cryptoswift_pod branch November 10, 2023 18:55
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
* Renove CryptoSwift Pod

* Revert abacus

* Rebase
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Renove CryptoSwift Pod

* Revert abacus

* Rebase
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Renove CryptoSwift Pod

* Revert abacus

* Rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants