Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Info.plist scheme for router. And updated Abacus #14

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented Nov 8, 2023

Description / Intuition

Router was using the scheme set up in web app. That may cause issues if the web app repo is not up to date on the local drive.


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

ruixhuang
ruixhuang previously approved these changes Nov 8, 2023
# Conflicts:
#	dydx/Podfile.lock
#	dydx/Pods/Local Podspecs/abacus.podspec.json
#	dydx/Pods/Manifest.lock
#	dydx/Pods/Pods.xcodeproj/project.pbxproj
#	podspecs/Abacus.podspec
# Conflicts:
#	dydx/Pods/Local Podspecs/abacus.podspec.json
#	dydx/Pods/Pods.xcodeproj/project.pbxproj
#	podspecs/Abacus.podspec
@ruixhuang ruixhuang merged commit e5df68d into main Nov 10, 2023
2 checks passed
@ruixhuang ruixhuang deleted the feature/use-scheme-from-bundle-for-router branch November 10, 2023 22:37
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
* Use the Info.plist scheme for router.
And updated Abacus

* Replaces other occurrences of AbacusStateManager.shared.appSetting?.scheme

* Update Cocoapods
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Use the Info.plist scheme for router.
And updated Abacus

* Replaces other occurrences of AbacusStateManager.shared.appSetting?.scheme

* Update Cocoapods
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Use the Info.plist scheme for router.
And updated Abacus

* Replaces other occurrences of AbacusStateManager.shared.appSetting?.scheme

* Update Cocoapods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants