Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3204 Update Abacus and v4-client #18

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented Nov 10, 2023

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3204


Description / Intuition

Only needed to update v4-client and Abacus to have Market order as FOK and closePosition as IOC


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

mike-dydx
mike-dydx previously approved these changes Nov 10, 2023
# Conflicts:
#	dydx/Pods/Pods.xcodeproj/project.pbxproj
@johnqh johnqh merged commit 6a17a92 into main Nov 10, 2023
2 checks passed
@johnqh johnqh deleted the feature/TRCL-3204-integrate-market-order-fok branch November 10, 2023 22:03
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants