TRCL-2841 : Trading Network current value not shown on Settings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnqh
approved these changes
Nov 10, 2023
johnqh
deleted the
mike/trcl-2841-trading-network-current-value-not-shown-on-settings
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* attempt to parse a trading network value * look up env in available environments instead * clean up
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* attempt to parse a trading network value * look up env in available environments instead * clean up
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* attempt to parse a trading network value * look up env in available environments instead * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-2841 : Trading Network current value not shown on Settings
Description / Intuition
issue is that we have json-configurable settings screens without support for current value look-ups. The solution was a best-effort look up a value/key in
availableEnvironmentsBefore/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-10.at.17.07.24.mp4
Type of Change