handle short position case for displaying liquidation price, live-update position row items #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
changed the title
prashanDYDX
reviewed
Jul 1, 2024
| let currentLeverage = input.summary?.positionLeverage?.doubleValue ?? 0 | ||
| let postLeverage = input.summary?.positionLeverageUpdated?.doubleValue ?? 0 | ||
|
|
||
| viewModel?.liquidationPrice = dydxAdjustMarginLiquidationPriceViewModel() | ||
|
|
||
| if input.summary?.positionLeverageUpdated == nil { | ||
| let hasNoInput = input.summary?.positionLeverageUpdated == nil |
There was a problem hiding this comment.
i've seen positionLeverageUpdated sometimes be a weird value. on android i'm just checking input.amount == nil
There was a problem hiding this comment.
if input.amount is "0" though or "000" etc, i wanted to avoid that
prashanDYDX
reviewed
Jul 1, 2024
| viewModel?.liquidationPrice?.direction = .none | ||
| if currentLeverage <= 1 { | ||
| if currentLeverage <= 1 && side == Abacus.PositionSide.long_ { |
There was a problem hiding this comment.
up to you on whether you want to simplify this if else - on Android i didn't end up doing any complex checks on leverage or side. i just used hasNoInput and liquidation price directly. if it is nil, it's because there is no liquidation price (leverage <= 1 and long).
There was a problem hiding this comment.
How did u decide to display "None" or not then?
prashanDYDX
approved these changes
Jul 1, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
…ate position row items (#205) * handle short position case for displaying liquidation price * remove viewmodel caching
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
…ate position row items (#205) * handle short position case for displaying liquidation price * remove viewmodel caching
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
…ate position row items (#205) * handle short position case for displaying liquidation price * remove viewmodel caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket:
Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=5956-16570&t=H5PO3Em25YfPWYom-4
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-01.at.12.27.31.mp4
Type of Change