Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cancel orders bug when orders cancellations fail #208

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Jul 2, 2024

Description / Intuition

  • fixed cancellation issue, previously was using unfiltered orderIds in the cancellation call
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-02.at.16.28.32.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@prashanDYDX prashanDYDX merged commit 62c4206 into develop Jul 2, 2024
2 checks passed
@prashanDYDX prashanDYDX deleted the mike/fix-cancel-orders branch July 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants