Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRCL-3207} Add FF settings to load custom deployment URL #21

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[TRCL-3207} Add FF settings to load custom deployment URL #21

merged 1 commit into from
Nov 10, 2023

Conversation

ruixhuang
Copy link
Contributor

@ruixhuang ruixhuang commented Nov 10, 2023 •
edited
Loading


Description / Intuition

Add FF settings to load custom deployment URL. Two settings have been added as shown here:

Simulator Screenshot - iPhone 15 Pro - 2023-11-10 at 14 43 38


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@linear Linear
Copy link

linear bot commented Nov 10, 2023

TRCL-3207 Add mainnet network to iOS testflight

@ruixhuang ruixhuang merged commit 93a4303 into main Nov 10, 2023
2 checks passed
@ruixhuang ruixhuang deleted the features/debug_deployment_url branch November 10, 2023 22:54
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
@ruixhuang @mike-dydx
Add FF settings to load custom deployment URL (#21)
9110419
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
@ruixhuang @mike-dydx
Add FF settings to load custom deployment URL (#21)
842a815
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
@ruixhuang @mike-dydx
Add FF settings to load custom deployment URL (#21)
cdf5299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnqh johnqh johnqh approved these changes

@mike-dydx mike-dydx Awaiting requested review from mike-dydx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @johnqh