default skip on, persist feature flags through session #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2816867.
mike-dydx
force-pushed
the
mike/default-skip-on
branch
from
f1542f0
to
7299786
Compare
mike-dydx
commented
Jul 29, 2024
| @@ -12,12 +12,6 @@ import Combine | |||
| public class CompositeFeatureFlagsProvider: NSObject & FeatureFlagsProtocol { | |||
| public var local: FeatureFlagsProtocol? | |||
| public var remote: FeatureFlagsProtocol? | |||
|
|
|||
| public var newValuesAvailablePublisher: AnyPublisher<Void, Never> { | |||
There was a problem hiding this comment.
no longer necessary since we are keeping session values constant for entire session after first access
ruixhuang
approved these changes
Jul 29, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* default to using skip * Revert "default to using skip" This reverts commit 2816867. * implement default value and session feature flag consistency * Delete contents.xcworkspacedata --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* default to using skip * Revert "default to using skip" This reverts commit 2816867. * implement default value and session feature flag consistency * Delete contents.xcworkspacedata --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* default to using skip * Revert "default to using skip" This reverts commit 2816867. * implement default value and session feature flag consistency * Delete contents.xcworkspacedata --------- Co-authored-by: Mike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Intuition
Before/After Screenshots or Videos
the below are print-outs for the
isOnfunction to exhibit how the feature flags behave session-to-sessionwith printing code:
note
force-mainnetis not on Statsig and thus alwaysunavailablefirst app launch:
second app launch:
3rd app launch after flag value was toggled to false in statsig (remember this will result in previously cached value_:
4th app launch after flag was toggled back to true in statsig (this will result in (step-1)'s value):
5ht app launch
Type of Change