CLI-627: vault landing screen graph #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
commented
Aug 7, 2024
| @@ -120,6 +120,7 @@ import Foundation | |||
| open func stringForValue(_ value: Double, axis _: AxisBase?) -> String { | |||
| var result: String = "" | |||
| if let anchor = GraphingAnchor.shared?.date { | |||
| // what is 2500 here? | |||
There was a problem hiding this comment.
@ruixhuang any idea on this number?
There was a problem hiding this comment.
Not sure... Try changing it and see how it looks
Comment on lines
+206
to
+211
| fileprivate class TimeAxisValueFormatter: DateFormatter, IAxisValueFormatter { | ||
| func stringForValue(_ value: Double, axis: AxisBase?) -> String { | ||
| let date = Date(timeIntervalSince1970: value) | ||
| return self.string(from: date) | ||
| } | ||
| } |
There was a problem hiding this comment.
The alternative DateTimeAxisFormatter seems to be doing a lot of work and it did not really match the vault designs for xAxis value formatting so I opted for a custom formatter which uses an out-of-the-box DateFormatter more or less. Unsure why DateTimeAxisFormatter is so complicated.
mike-dydx
commented
Aug 7, 2024
Comment on lines
+106
to
+115
| // TODO: delete and replace with real data | ||
| private var cancellables = Set<AnyCancellable>() | ||
| init() { | ||
| super.init() | ||
| Timer.publish(every: 1, triggerNow: true) | ||
| .sink { [weak self] _ in | ||
| self?.setEntries() | ||
| } | ||
| .store(in: &cancellables) | ||
| } |
There was a problem hiding this comment.
just for testing before abacus is hooked up
mike-dydx
commented
Aug 7, 2024
Comment on lines
+66
to
+73
| //TODO: remove | ||
| // this is just for testing | ||
| let now = Date().timeIntervalSince1970 | ||
| let finalTimeSecondsAway = selectedValueTime == .oneDay ? 3600.0*24.0 : selectedValueTime == .sevenDays ? 3600.0*24.0*7.0 : 3600.0*24.0*30.0 | ||
| let numEntries = Int.random(in: 0..<100) | ||
| let entries = (0..<numEntries).map { i in | ||
| ChartDataEntry(x: now + Double(i)/Double(numEntries) * finalTimeSecondsAway, y: Double.random(in: 0..<100)) | ||
| } |
There was a problem hiding this comment.
just for testing before abacus is hooked up
ruixhuang
approved these changes
Aug 8, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* add chart radio buttons * fine tune graph * comment * comment --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add chart radio buttons * fine tune graph * comment * comment --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add chart radio buttons * fine tune graph * comment * comment --------- Co-authored-by: Mike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: CLI-627: vault landing screen graph
Figma Design: design
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-07.at.11.43.50.mp4
Type of Change