Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-638: prediction markets UI #222

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

mike-dydx
Copy link
Collaborator

@mike-dydx mike-dydx commented Aug 8, 2024

Links (dYdX Internal Use Only)

Linear Ticket: CLI-638: [iOS] prediction markets UI

Figma Design: design


Description / Intuition

  • new banner above markets with cta for user to trade trump-usd
  • new prediction market filter (uses tag "Prediction Market") from the markets.json

Before/After Screenshots or Videos

Descript Before After
feature flag on
feature flag on
feature flag off (should be same)
feature flag off (should be same)
see debugger output to confirm correct end date

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Aug 8, 2024

@mike-dydx mike-dydx marked this pull request as ready for review August 8, 2024 01:01
@mike-dydx mike-dydx merged commit c2cd3da into develop Aug 9, 2024
2 checks passed
@mike-dydx mike-dydx deleted the mike/cli-638-prediction-markets-ui branch August 9, 2024 16:07
mike-dydx added a commit that referenced this pull request Aug 20, 2024
* add feature flag

* support filtering to prediction markets

* add banner

* comment

* add feature flag to debug menu

---------

Co-authored-by: Mike <[email protected]>
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* add feature flag

* support filtering to prediction markets

* add banner

* comment

* add feature flag to debug menu

---------

Co-authored-by: Mike <[email protected]>
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* add feature flag

* support filtering to prediction markets

* add banner

* comment

* add feature flag to debug menu

---------

Co-authored-by: Mike <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants