-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-628: vault landing screen positions list #228
Closed
mike-dydx
wants to merge
236
commits into
develop
from
mike/cli-628-vault-landing-screen-positions-list
Closed
CLI-628: vault landing screen positions list #228
mike-dydx
wants to merge
236
commits into
develop
from
mike/cli-628-vault-landing-screen-positions-list
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lost-the-animation TRCL-3095 : Orderbook asks lost the animation
* Clean up MarketInfo data and add SwiftLint action * yml * yml1 * yml3 * Revert
…nces-in-text-color-make-both-primary TRCL-3055 : Market: differences in text color? make both secondary
* Add Swiftlint to bit pre-commit
…a-trade-ensure-user-stays-on-the-market-they TRCL-3052 : After placing a trade, ensure user stays on the market they just traded on instead of being routed back to the overall markets page or portfolio page
Feature/trcl 3132 market details
[TRCL-3160] Load app scheme from env.json and add scripts to update the info.plist
…-and-created-at-in-ios-app
* Renove CryptoSwift Pod * Revert abacus * Rebase
* attempt to parse a trading network value * look up env in available environments instead * clean up
* use skip true * bump abacus to 1.8.39 * Update AbacusStateManager.swift * add placeholder for alchemyApiKey * bump abacus to 1.8.43 * inject alchemy api key * fix set schema script * bump abacus * read from v1 configs --------- Co-authored-by: Mike <[email protected]>
* bump abacus * update v4-native-client.js to include new cctpMultiMsgWithdraw transaction type --------- Co-authored-by: Mike <[email protected]>
* create slider text input view * add target leverage slider * temp * fix custom amount switch behavior and fix overwriting bug * undo changes to platforminput * fix lines to 1 for leverage buttons * temp * fix precision * add precision to slider * clean up * address PR comments --------- Co-authored-by: Mike <[email protected]>
* integrate statsig * comment * remove FirebaseRemoteConfig * add skip to features.json * change inputs to on/off * integrate statsig with featureflag protocol * comment * change assertion failure to log * delete file * deleted code * comment * Update PodFile * bump abacus * fix pods? * remove unnecessary import --------- Co-authored-by: Mike <[email protected]>
* default to using skip * Revert "default to using skip" This reverts commit 2816867. * implement default value and session feature flag consistency * Delete contents.xcworkspacedata --------- Co-authored-by: Mike <[email protected]>
* add vault feature flag * vault screen top section stubbed out * add apr-tvl row --------- Co-authored-by: Mike <[email protected]>
* add chart radio buttons * fine tune graph * comment * comment --------- Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike <[email protected]>
* add feature flag * support filtering to prediction markets * add banner * comment * add feature flag to debug menu --------- Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike <[email protected]>
* make userInfo [String: Any] * pod update, adopt amplitude swift * add statsig init listener to dydxCompositeTracking * remove schemes, re-apply pod update * clean up * fixes & address PR feedback move up injectAmplitude in the lifecycle remove firebase from dydxAnalytics rename function chop characters to 36 for firebase user property --------- Co-authored-by: Mike <[email protected]>
* add footer text when prediction markets is selected filter * presenting prediction markets notice * new `present_over_full_screen` presentation style * speed up animation, improve timing for trade input presentation * add checkbox * remove test code * touchups * change logic to display prediction markets notice --------- Co-authored-by: Mike <[email protected]>
…227) * improve auto-sweep, default to subaccount 0 * clean up --------- Co-authored-by: Mike <[email protected]>
mike-dydx
changed the title
Mike/cli 628 vault landing screen positions list
CLI-628: vault landing screen positions list
Aug 19, 2024
* bump abacus * turn off forcing prediction markets notice * fix empty descriptions * remove unused `id` from SharedMarketViewModel * show display ID instead of market id in market details * rename marketXYZ to assetXYZ in isolated cancellation view model * use displayid for market mode selector * SharedMarketViewModel's `tokenSymbol` and `tokenFullName` renamed to `assetId` and `assetName` * fix filter scroll truncation --------- Co-authored-by: Mike <[email protected]>
mike-dydx
force-pushed
the
mike/cli-628-vault-landing-screen-positions-list
branch
from
August 19, 2024 22:29
36b3297
to
3828094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: CLI-628: vault landing screen positions list
Figma Design: designs
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-08-19.at.10.04.33.mp4
Type of Change