Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix feature flag initialization ordering #236

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix feature flag initialization ordering #236

merged 3 commits into from
Aug 22, 2024

Conversation

mike-dydx
Copy link
Contributor

Description / Intuition

  • fixes ordering of feature flag initialization and abacus initialization (note this was not affecting outside of DEBUG since the affected feature flag is a debug-only feature flag not managed by statsig)
  • adds logging output for analytics initialization

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx changed the title Mike/fix env selection 2 fix feature flag initialization ordering Aug 22, 2024
@mike-dydx mike-dydx enabled auto-merge (squash) August 22, 2024 00:43
@mike-dydx mike-dydx merged commit f5efbf2 into develop Aug 22, 2024
5 checks passed
@mike-dydx mike-dydx deleted the mike/fix-env-selection-2 branch August 22, 2024 00:54
mike-dydx added a commit that referenced this pull request Oct 14, 2024
@mike-dydx
fix feature flag initialization ordering (#236)
b0ec449 
* reorder analytics initialization after feature flag initialization

* add logging

* Update StatsigInjections.swift

---------

Co-authored-by: Mike <[email protected]>
mike-dydx added a commit that referenced this pull request Oct 14, 2024
@mike-dydx
fix feature flag initialization ordering (#236)
435cb58 
* reorder analytics initialization after feature flag initialization

* add logging

* Update StatsigInjections.swift

---------

Co-authored-by: Mike <[email protected]>
mike-dydx added a commit that referenced this pull request Oct 16, 2024
@mike-dydx
fix feature flag initialization ordering (#236)
7155ec8 
* reorder analytics initialization after feature flag initialization

* add logging

* Update StatsigInjections.swift

---------

Co-authored-by: Mike <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-dydx @ruixhuang