Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FF for Abacus static typing #239

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add FF for Abacus static typing #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dydx/dydxFormatter/dydxFormatter/_Utils/dydxFeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public enum dydxBoolFeatureFlag: String, CaseIterable {
case shouldUseSkip = "ff_skip_migration"
case isVaultEnabled = "ff_vault_enabled"
case showPredictionMarketsUI = "ff_show_prediction_markets_ui"
case abacus_static_typing

var defaultValue: Bool {
switch self {
Expand All @@ -28,6 +29,8 @@ public enum dydxBoolFeatureFlag: String, CaseIterable {
return false
case .showPredictionMarketsUI:
return false
case .abacus_static_typing:
return false
}
}

Expand Down
20 changes: 20 additions & 0 deletions dydx/dydxPresenters/dydxPresenters/_Features/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,26 @@
}
]
}
},
{
"title":{
"text":"Abacus Static Typing"
},
"field":{
"field":"abacus_static_typing",
"optional":true,
"type" : "bool",
"options" : [
{
"text": "yes",
"value" : 1
},
{
"text": "no",
"value" : 0
}
]
}
}
]
}
Expand Down
1 change: 1 addition & 0 deletions dydx/dydxStateManager/dydxStateManager/AbacusStateManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ public final class AbacusStateManager: NSObject {
appConfigs.onboardingConfigs.squidVersion = OnboardingConfigs.SquidVersion.v2
appConfigs.onboardingConfigs.alchemyApiKey = CredientialConfig.shared.credential(for: "alchemyApiKey")
StatsigConfig.shared.useSkip = dydxBoolFeatureFlag.shouldUseSkip.isEnabled
appConfigs.staticTyping = dydxBoolFeatureFlag.abacus_static_typing.isEnabled

return AsyncAbacusStateManagerV2(
deploymentUri: deploymentUri,
Expand Down
Loading