Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-631: Draft Deposit/Withdrawal Screen UI #243

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mike-dydx
Copy link
Collaborator

@mike-dydx mike-dydx commented Sep 9, 2024

Links (dYdX Internal Use Only)

Linear Ticket: CLI-631: Draft Deposit/Withdrawal Screen UI

Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=9752-2618&t=sypqKCy820t94K6p-4


Description / Intuition

  • note there is some spoofing/test code that will be removed

Before/After Screenshots or Videos

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-10.at.12.17.49.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Sep 9, 2024

@mike-dydx mike-dydx force-pushed the mike/cli-632-confirm-depositwithdraw-screen branch 2 times, most recently from 16becd0 to a3c944d Compare September 10, 2024 02:17
add checkbox and alert to confirmation screen
@mike-dydx mike-dydx force-pushed the mike/cli-632-confirm-depositwithdraw-screen branch from a3c944d to 053f7db Compare September 10, 2024 02:31
@mike-dydx mike-dydx marked this pull request as ready for review September 10, 2024 16:19
@mike-dydx mike-dydx changed the title Mike/cli 632 confirm depositwithdraw screen CLI-631: Draft Deposit/Withdrawal Screen UI Sep 10, 2024
Copy link

linear bot commented Sep 10, 2024

@mike-dydx mike-dydx merged commit b561952 into develop Sep 10, 2024
5 checks passed
@mike-dydx mike-dydx deleted the mike/cli-632-confirm-depositwithdraw-screen branch September 10, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants