Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3683 Add new filter items #245

Merged
merged 5 commits into from
Sep 13, 2024
Merged

TRCL-3683 Add new filter items #245

merged 5 commits into from
Sep 13, 2024

Conversation

ruixhuang
Copy link
Contributor


Description / Intuition

Add market filter items to match what's on the web FE.


Before/After Screenshots or Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-11.at.13.02.49.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

# Conflicts:
#	dydx/Podfile.lock
#	dydx/Pods/AmplitudeSwift/Sources/Amplitude/Constants.swift
#	dydx/Pods/Local Podspecs/abacus.podspec.json
#	dydx/Pods/Manifest.lock
#	dydx/Pods/Pods.xcodeproj/project.pbxproj
#	dydx/Pods/Target Support Files/AmplitudeSwift/AmplitudeSwift-Info.plist
#	dydx/Pods/Target Support Files/AmplitudeSwift/ResourceBundle-Amplitude-AmplitudeSwift-Info.plist
#	podspecs/Abacus.podspec
Copy link

linear bot commented Sep 11, 2024

@ruixhuang ruixhuang marked this pull request as ready for review September 11, 2024 20:04
@mike-dydx mike-dydx self-requested a review September 13, 2024 00:49
@mike-dydx mike-dydx merged commit c1512e0 into develop Sep 13, 2024
5 checks passed
@mike-dydx mike-dydx deleted the features/add_filters branch September 13, 2024 00:50
mike-dydx pushed a commit that referenced this pull request Oct 16, 2024
* Bump Abacus

* Turn on static_typing as default

* WIP

* Fix ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants