TRCL-3689 Add primer screen to prompt the user to enable notification #251
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // | ||
| // dydxPushNotificationToggleWorker.swift | ||
| // dydxPresenters | ||
| // | ||
| // Created by Rui Huang on 13/09/2024. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Combine | ||
| import dydxStateManager | ||
| import ParticlesKit | ||
| import RoutingKit | ||
| import Utilities | ||
|
|
||
| public final class dydxPushNotificationToggleWorker: BaseWorker { | ||
|
|
||
| public override func start() { | ||
| super.start() | ||
|
|
||
| // Sync the app settings value to the system notification settings | ||
| changeObservation(from: nil, to: NotificationService.shared, keyPath: #keyPath(NotificationHandler.permission)) { _, _, _, _ in | ||
| let pushNotificationEnabled = NotificationService.shared?.permission == .authorized | ||
| SettingsStore.shared?.setValue(pushNotificationEnabled, forKey: dydxSettingsStoreKey.shouldDisplayInAppNotifications.rawValue) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // | ||
| // dydxNotificationPrimerViewPresenter.swift | ||
| // dydxPresenters | ||
| // | ||
| // Created by Rui Huang on 11/09/2024. | ||
| // | ||
|
|
||
| import Utilities | ||
| import dydxViews | ||
| import PlatformParticles | ||
| import RoutingKit | ||
| import ParticlesKit | ||
| import PlatformUI | ||
|
|
||
| public class dydxNotificationPrimerViewBuilder: NSObject, ObjectBuilderProtocol { | ||
| public func build<T>() -> T? { | ||
| let presenter = dydxNotificationPrimerViewPresenter() | ||
| let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() | ||
| return dydxNotificationPrimerViewController(presenter: presenter, view: view, configuration: .default) as? T | ||
| } | ||
| } | ||
|
|
||
| private class dydxNotificationPrimerViewController: HostingViewController<PlatformView, dydxNotificationPrimerViewModel> { | ||
| override public func arrive(to request: RoutingRequest?, animated: Bool) -> Bool { | ||
| if request?.path == "/primer/notification" { | ||
| return true | ||
| } | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| private protocol dydxNotificationPrimerViewPresenterProtocol: HostedViewPresenterProtocol { | ||
| var viewModel: dydxNotificationPrimerViewModel? { get } | ||
| } | ||
|
|
||
| private class dydxNotificationPrimerViewPresenter: HostedViewPresenter<dydxNotificationPrimerViewModel>, dydxNotificationPrimerViewPresenterProtocol { | ||
| override init() { | ||
| super.init() | ||
|
|
||
| viewModel = dydxNotificationPrimerViewModel() | ||
| viewModel?.ctaAction = { | ||
| Router.shared?.navigate(to: RoutingRequest(path: "/action/dismiss", params: nil), animated: true) { _, _ in | ||
| let notificationPermission = NotificationService.shared?.authorization | ||
| if notificationPermission?.authorization == .notDetermined { | ||
| notificationPermission?.promptToAuthorize() | ||
| } | ||
|
Comment on lines
+44
to
+46
There was a problem hiding this comment. if forget, is There was a problem hiding this comment. Yeah, we should only show the primer when the state is .notDetermined, since it's the only time the app can prompt for the system notification toggle. In other cases, user has to manually toggle through the device's Settings. .ephemeral is only available for app clips. |
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So subclass can overwrite with custom behavior.