Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI-625: reflect vault balance in portfolio positions #252

Merged
merged 1 commit into from
Sep 18, 2024
Merged

CLI-625: reflect vault balance in portfolio positions #252

merged 1 commit into from
Sep 18, 2024

Conversation

mike-dydx
Copy link
Contributor

Links (dYdX Internal Use Only)

Linear Ticket: CLI-625: reflect vault balance in portfolio positions

Figma Design: design


Description / Intuition

  • adds vault balance row to portfolio screen behind a feature flag
  • replaces vault strings with "megavault" string
  • note there is some spoofing/placeholder values

Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@linear Linear
Copy link

linear bot commented Sep 17, 2024

CLI-625 reflect vault balance in portfolio positions

mike-dydx
mike-dydx commented Sep 17, 2024
View reviewed changes
dydx/dydxViews/dydxViews/Media.xcassets/icon_chain.imageset/icon_token.pdf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note icon_token was not being used prior to rename. It is this image which is the chain, not the token

@mike-dydx mike-dydx force-pushed the mike/cli-625-reflect-vault-balance-in-portfolio-positions branch 2 times, most recently from d7fc5b4 to 5b91747 Compare September 17, 2024 20:54
@mike-dydx mike-dydx force-pushed the mike/cli-625-reflect-vault-balance-in-portfolio-positions branch from 5b91747 to 09b16fe Compare September 17, 2024 21:01
@mike-dydx mike-dydx merged commit ac3cc50 into develop Sep 18, 2024
5 checks passed
@mike-dydx mike-dydx deleted the mike/cli-625-reflect-vault-balance-in-portfolio-positions branch September 18, 2024 16:04
mike-dydx added a commit that referenced this pull request Oct 16, 2024
@mike-dydx
add megavault portfolio row item (#252)
df9714b 
Co-authored-by: Mike <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-dydx @ruixhuang