CLI-624: move alerts out of tab navigation into to settings #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
changed the title
mike-dydx
commented
Sep 18, 2024
| @@ -19,7 +19,7 @@ public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { | |||
| public func build<T>() -> T? { | |||
| let presenter = dydxMarketInfoViewPresenter() | |||
| let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() | |||
| let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) | |||
| let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .default) | |||
There was a problem hiding this comment.
nav is exactly the same as default
mike-dydx
commented
Sep 18, 2024
| @@ -33,7 +33,6 @@ public struct HostingViewControllerConfiguration { | |||
| public static let `default` = HostingViewControllerConfiguration(ignoreSafeArea: false, fixedHeight: nil, gradientTabbar: false) | |||
| public static let ignoreSafeArea = HostingViewControllerConfiguration(ignoreSafeArea: true) | |||
| public static let tabbarItemView = HostingViewControllerConfiguration(ignoreSafeArea: false, fixedHeight: nil, gradientTabbar: true) | |||
| public static let nav = HostingViewControllerConfiguration(ignoreSafeArea: false, fixedHeight: nil, gradientTabbar: false, disableNavigationController: false) | |||
There was a problem hiding this comment.
see line 21 to confirm nav was same as default
mike-dydx
commented
Sep 18, 2024
Comment on lines
+65
to
+66
| // offset for tab bar. comes from dydxV4TabBarBuilder's center button height | ||
| .padding(.bottom, 30) |
There was a problem hiding this comment.
this seems to be how we do it elsewhere 😞 unsure if there's a good solution right now to improve other than adding a comment
|
The vault tab icon doesn't look like the same size as other tab icons. I think we should increase its size. Also, the icon looks like a "close" button. 
|
ruixhuang
approved these changes
Sep 18, 2024
ruixhuang
approved these changes
Sep 23, 2024
mike-dydx
force-pushed
the
mike/cli-624-move-alerts-out-of-tab-navigation-into-to-settings
branch
from
a378322
to
31c0e5b
Compare
mike-dydx
force-pushed
the
mike/cli-624-move-alerts-out-of-tab-navigation-into-to-settings
branch
from
31c0e5b
to
8241c48
Compare
mike-dydx
deleted the
mike/cli-624-move-alerts-out-of-tab-navigation-into-to-settings
branch
mike-dydx
added a commit
that referenced
this pull request
Oct 16, 2024
* move alerts routing to settings screen * showing alerts * rename & delete old files * add back button * conditionally hide/show alerts based on onboarding status and feature flag * rename * rename again * move tab config out of json * improve tab bar gradient and app theme update propagation --------- Co-authored-by: Mike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: CLI-624: move alerts out of tab navigation into to settings
Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=9615-982&t=QjiTEfHMhHzJgIrk-4
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.Mainnet.-.2024-09-23.at.13.31.49.mp4
Type of Change