Sync system notification settings; filter out Abacus notifications #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dydx/dydxPresenters/dydxPresenters.xcodeproj/project.pbxproj # dydx/dydxPresenters/dydxPresenters/_v4/GlobalWorkers/dydxGlobalWorkers.swift
# Conflicts: # dydx/dydxStateManager/dydxStateManager/AbacusStateManager.swift
ruixhuang
commented
Sep 18, 2024
| if successful.boolValue { | ||
| if let self = self { | ||
| self.keyValueStore?.setValue(code, forKey: self._languageTag) | ||
| let localizer = UIImplementations.shared?.localizer as? DynamicLocalizer |
There was a problem hiding this comment.
Add some logging; no functional change
mike-dydx
reviewed
Sep 18, 2024
| import RoutingKit | ||
| import Utilities | ||
|
|
||
| public final class dydxPushNotifcationToggleWorker: BaseWorker { |
mike-dydx
approved these changes
Sep 18, 2024
Comment on lines
+49
to
+51
| viewModel?.cancelAction = { | ||
| Router.shared?.navigate(to: RoutingRequest(path: "/action/dismiss", params: nil), animated: true, completion: nil) | ||
| } |
| @@ -57,7 +65,10 @@ private class dydxNotificationsSettingsViewPresenter: SettingsViewPresenter { | |||
| cancelTitle: DataLocalizer.shared?.localize(path: "APP.GENERAL.CANCEL", params: nil) ?? "Cancel" | |||
| ) | |||
| } | |||
| // sync the settings with the system permission | |||
| reloadSettings() | |||
There was a problem hiding this comment.
would this get called while user is being prompted to turn on notifications? Does this have an effect?
There was a problem hiding this comment.
Yeah.. it gets called, which sets the value back... But when the system notification value changes, it will be synced again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Intuition
Various updates for push notifications:
Type of Change