Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3698 Add user property tracking for push notification #259

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

ruixhuang
Copy link
Contributor

Had to move around the code a bit due to the initialization sequence of Tracking.shared and NotificationService.share.


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review September 18, 2024 21:28
@ruixhuang ruixhuang changed the title Add user property tracking for push notification TRCL-3698 Add user property tracking for push notification Sep 18, 2024
Copy link

linear bot commented Sep 18, 2024

@mike-dydx mike-dydx self-requested a review September 20, 2024 14:05
@mike-dydx mike-dydx merged commit ec99284 into develop Sep 20, 2024
5 checks passed
@mike-dydx mike-dydx deleted the features/push_3 branch September 20, 2024 14:06
mike-dydx pushed a commit that referenced this pull request Oct 16, 2024
* Add user property tracking

* Update to "Not Now"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants