Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Clean up MarketInfo data and add SwiftLint action #3

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

ruixhuang
Copy link
Contributor

@ruixhuang ruixhuang commented Nov 6, 2023

Links

Linear Ticket: [Provide link to Linear ticket issue]

Figma Design: [Provide link to Figma design here if applicable]


Description / Intuition

Fix wrong data in the market info and make them consistent with web FE and Android.

Also added SwiftLint action to PR.


Before/After Screenshots or Videos

Before After
before image{: width="300px" } after image{: width="300px" }
before image{: width="300px" } after image{: width="300px" }

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Additional Comments (optional)

Provide any additional comments or context about the changes here.

@mike-dydx mike-dydx merged commit 6b7aab9 into main Nov 6, 2023
2 checks passed
@mike-dydx mike-dydx added this to the v1.0.0 milestone Nov 10, 2023
@ruixhuang ruixhuang deleted the features/configs branch January 22, 2024 15:53
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
* Clean up MarketInfo data and add SwiftLint action

* yml

* yml1

* yml3

* Revert
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Clean up MarketInfo data and add SwiftLint action

* yml

* yml1

* yml3

* Revert
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Clean up MarketInfo data and add SwiftLint action

* yml

* yml1

* yml3

* Revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants