Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3052 : After placing a trade, ensure user stays on the market they just traded on instead of being routed back to the overall markets page or portfolio page #7

Conversation

mike-dydx
Copy link
Collaborator

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3052 : After placing a trade, ensure user stays on the market they just traded on instead of being routed back to the overall markets page or portfolio page


Description / Intuition

from design:

I think that the user should end up on the market info screen after they place a trade.
The reason being is that sometimes users have a few trades within a given strategy, and they're still able to see their position info from the market info screen.


Before/After Screenshots or Videos

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-07.at.12.04.53.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-07.at.12.03.58.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx self-assigned this Nov 7, 2023
@mike-dydx mike-dydx added this to the v1.0.0 milestone Nov 7, 2023
@ruixhuang ruixhuang merged commit 27e73e0 into main Nov 7, 2023
2 checks passed
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
…a-trade-ensure-user-stays-on-the-market-they

TRCL-3052 : After placing a trade, ensure user stays on the market they just traded on instead of being routed back to the overall markets page or portfolio page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants