Fix loop merge bookkeeping #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sources/dfmc/flow-graph/utilities.dylan (delete-computation! on <loop-merge>): Override to properly remove dead loop merges from the auxiliary collections kept within <loop> and <loop-call> nodes.
This adds a regression test for issue 1523, a compilation failure that occurrs when loop merges are deleted as dead code. * sources/dylan/tests/regressions.dylan (test issue-1523): New test with a loop merge eligible for deletion.
cgay
approved these changes
Jul 1, 2024
waywardmonkeys
approved these changes
Jul 1, 2024
housel
merged commit ba2348e
into
dylan-lang:1523-no-value-defined-for-temporary
1 check passed
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1461, #1523