Fix push-last #1625
Merged
Fix push-last #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgay
reviewed
Jul 31, 2024
According to the DRM, the push-last function is supposed to return the new value added to a deque rather than the deque. * sources/dylan/deque.dylan (trusted-push-last): Change to return the new element. (push-last): Change return signature to reflect returning the new element. * sources/dylan/tests/collections.dylan (test test-<deque>-functions): New test (inspired by cmu-test-suite) for testing <deque>-specific functions and methods. (suite dylan-collections-test-suite): Add test-<deque>-functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a mismatch between the DRM specification of push-last and the Open Dylan implementation.