Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sequencer): permissioned addresses are not added on genesis #407

Closed
wants to merge 7 commits into from

Conversation

srene
Copy link
Contributor

@srene srene commented Apr 26, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #406

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Apr 26, 2024
@srene srene requested a review from a team as a code owner April 26, 2024 12:29
danwt
danwt previously approved these changes Apr 26, 2024
@omritoptix omritoptix dismissed danwt’s stale review May 5, 2024 13:24

The merge-base changed after approval.

@omritoptix
Copy link
Contributor

@srene not sure what it is. can we close this?

@srene
Copy link
Contributor Author

srene commented May 21, 2024

i think this PR was created to solve the issues related with the modifications in #384. The problem afair was that the whitelistedaddresses were not loaded and therefore not possible to create denoms by those. However, i think those modifications were reverted before nim rollap release, but not sure what is the status of it now.

@srene
Copy link
Contributor Author

srene commented May 21, 2024

I close this PR since it is not relevant anymore

@srene srene closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollapp fails to create denom metadata
6 participants