Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(upstream): upstream fixes for v1.2.0 #1017

Merged
merged 11 commits into from
Aug 13, 2024
Merged

chore(upstream): upstream fixes for v1.2.0 #1017

merged 11 commits into from
Aug 13, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

hoangdv2429 and others added 11 commits July 30, 2024 12:41
@hoangdv2429
chore: add Initial changelog (#990)
9e3201d
@zale144
fix(rpc): Fix status CatchingUp field updating (#971)
402dd00
@mtsitrin @danwt
tests(pruning): Add pruning unit-test (#996)
83078f5 
Co-authored-by: danwt <[email protected]>
@danwt @omritoptix
hotfix(submit): early catch and log for empty batch (#997)
93905ee 
Co-authored-by: Omri <[email protected]>
@danwt
fix(submit loop): add more logging around skew calculation (#1000)
0bbe5be
@srene @coderabbitai
@mtsitrin @omritoptix @danwt
feat(p2p): block sync protocol (#915)
4c9c2c3 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Michael Tsitrin <[email protected]>
Co-authored-by: Omri <[email protected]>
Co-authored-by: Daniel T <[email protected]>
@danwt
fix(local pub sub): fix must subscribe to handle context cancelled (#…
01fc2d5 
…1002)
@danwt
fix(test): submit loop test uses no op logger and prints more diagnos…
d3b4311 
…tics (#1003)
@srene
refactor(p2p): rename p2p block event (#1006)
603c160
@danwt
fix(submit loop): correctly load commit on startup (#1011)
f3e69a3
@srene
fix(manager): full-node syncing fix (#1013)
fab177a
@omritoptix omritoptix requested a review from a team as a code owner August 13, 2024 07:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 13, 2024
View reviewed changes
block/manager.go
Comment on lines +168 to +171
go func() {
_ = eg.Wait() // errors are already logged
m.logger.Info("Block manager err group finished.")
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
p2p/client.go
func (c *Client) startBlockSync(ctx context.Context) error {
blocksync := SetupBlockSync(ctx, c.Host, c.blockSyncStore, c.logger)
c.blocksync = blocksync
go c.retrieveBlockSyncLoop(ctx, c.blockSyncReceived)

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
p2p/client.go
blocksync := SetupBlockSync(ctx, c.Host, c.blockSyncStore, c.logger)
c.blocksync = blocksync
go c.retrieveBlockSyncLoop(ctx, c.blockSyncReceived)
go c.advertiseBlockSyncCids(ctx)

Check notice

Code scanning / CodeQL

Spawning a Go routine Note

Spawning a Go routine may be a possible source of non-determinism
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 13, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@omritoptix omritoptix merged commit 0dba52d into release/v1.2.x Aug 13, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@omritoptix @hoangdv2429 @zale144 @mtsitrin @danwt @srene