Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager): rename rollappConsensusParams to rollappParams #1065

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Sep 6, 2024

PR Standards

for consistency with other libraries


Close #1066

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner September 6, 2024 14:52
@srene srene self-assigned this Sep 6, 2024
@omritoptix omritoptix changed the title feat(manager): rename rollapp consensus params to rollapp params refactor(manager): rename rollapp consensus params to rollapp params Sep 6, 2024
@omritoptix omritoptix changed the title refactor(manager): rename rollapp consensus params to rollapp params refactor(manager): rename rollappConsensusParams to rollappParams Sep 6, 2024
@omritoptix omritoptix merged commit 2da988f into main Sep 6, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/rollapp_params_rename branch September 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename RollappConsensusParams to RollappParams
2 participants