Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(da): grpc da error batch size above limit #1081

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Sep 18, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1080

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner September 18, 2024 08:49
danwt
danwt previously approved these changes Sep 18, 2024
anhductn2001
anhductn2001 previously approved these changes Sep 19, 2024
@mtsitrin mtsitrin dismissed stale reviews from anhductn2001 and danwt via 1a282c6 September 19, 2024 10:13
@mtsitrin mtsitrin merged commit 22a222e into main Sep 19, 2024
6 checks passed
@mtsitrin mtsitrin deleted the srene/1080-da-grpc-blobmaxbytes-fix branch September 19, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error using grpc da
4 participants