feat: Add support for avail as a DA #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 55.39% 52.29% -3.11%
==========================================
Files 86 89 +3
Lines 13234 14197 +963
==========================================
+ Hits 7331 7424 +93
- Misses 4879 5740 +861
- Partials 1024 1033 +9
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mtsitrin
reviewed
Jun 19, 2023
| @@ -158,6 +160,8 @@ func TestProduceOnlyAfterSynced(t *testing.T) { | |||
| <-ctx.Done() | |||
| require.Greater(t, manager.store.Height(), lastStoreHeight) | |||
| assert.Equal(t, batch.EndHeight, manager.store.Height()) | |||
| // Wait until manager is done | |||
| time.Sleep(time.Second * 4) | |||
There was a problem hiding this comment.
why u need it? isn't the manager stopped by the context already?
There was a problem hiding this comment.
yes it is but it takes the manager time due to the other case running (so the context.Done() case doesn't get a context switch immediately but only after a few seconds).
the tests kept failing so this fixed it.
prob it's bit dirty. if you have a better idea..
omritoptix
commented
Jun 19, 2023
config/toml.go
Outdated
| # da_config = "{\"base_url\": \"http://127.0.0.1:26659\", \"timeout\": 60000000000, \"fee\":20000, \"gas_limit\": 20000000, \"namespace_id\":\"000000000000ffff\"}" | ||
| da_config = "{{ .DAConfig }}" | ||
| # Avail config example: | ||
| # da_config = “{\“seed\“: \“MNEMONIC\“, \“api_url\“: \“wss://kate.avail.tools/ws\“, \“app_id\“: 0, \“tip\“:10}“, |
There was a problem hiding this comment.
seems like there are curly quotes (vs straight quotes)
mtsitrin
previously approved these changes
Jun 21, 2023
mtsitrin
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to provide with a stable avail client to dymint.
Currently there is a tx size limitation of 15kb on avail side which makes it unusable for dymint due to (at least) 2 reasons:
The issues were discussed with the avail team and they are working on increasing the max tx size ASAP.
Either way we can merge it and it should be usable once they do.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: