Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed namespaceID parsing from toml #373

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner June 26, 2023 10:18
@mtsitrin mtsitrin linked an issue Jun 26, 2023 that may be closed by this pull request
@mtsitrin mtsitrin requested a review from omritoptix June 26, 2023 12:13
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #373 (081c3c5) into main (1a683ca) will decrease coverage by 0.11%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   52.25%   52.14%   -0.11%     
==========================================
  Files          89       90       +1     
  Lines       14197    14216      +19     
==========================================
- Hits         7418     7413       -5     
- Misses       5745     5761      +16     
- Partials     1034     1042       +8     
Impacted Files Coverage Δ
da/celestia/celestia.go 64.92% <20.00%> (-2.07%) ⬇️
da/celestia/config.go 62.50% <62.50%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

}

// Define an auxiliary type to prevent infinite recursion in UnmarshalJSON
type auxConfig struct {
Copy link
Contributor

@omritoptix omritoptix Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't really like the duplication here. if I understand correctly the goal is to parse namespace id from string to bytes. I believe previously it has been done in the config file.
why do you think using AuxConfig is preferred?
Another option is possibly to add a field to the main config.
Creating 2 config which are basically the same but one field seems very confusing to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll figure out better way

@mtsitrin mtsitrin merged commit b38719a into main Jun 27, 2023
@mtsitrin mtsitrin deleted the mtsitrin/372-error-parsing-namespaceid-from-toml-file branch June 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error parsing namespaceID from toml file
2 participants