Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dymint out of sync with hub on tx submission timeout #404

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Jul 17, 2023

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner July 17, 2023 09:58
@omritoptix omritoptix linked an issue Jul 17, 2023 that may be closed by this pull request
@mtsitrin
Copy link
Contributor

@omritoptix build failed

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #404 (4740636) into main (d690b09) will decrease coverage by 1.08%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   52.51%   51.44%   -1.08%     
==========================================
  Files          92       92              
  Lines       14342    14343       +1     
==========================================
- Hits         7532     7379     -153     
- Misses       5740     5926     +186     
+ Partials     1070     1038      -32     
Impacted Files Coverage Δ
settlement/dymension/dymension.go 70.08% <50.00%> (-0.21%) ⬇️
da/celestia/celestia.go 64.92% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix merged commit 87343ed into main Jul 20, 2023
4 of 5 checks passed
@omritoptix omritoptix deleted the omritoptix/397-out-of-sync branch July 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out of sync issue with hub
3 participants