fix: possible race condition with small batches upon batch submission #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement latestHeight and manager batch submission.
|
@omritoptix tests fails |
mtsitrin
reviewed
Jul 19, 2023
settlement/base.go
Outdated
| @@ -164,16 +165,25 @@ func (b *BaseLayerClient) stateUpdatesHandler(ready chan bool) { | |||
| panic(err) | |||
| } | |||
| ready <- true | |||
| b.logger.Info("state updates handler ready") | |||
There was a problem hiding this comment.
should be probably debug
or better informative
ItzhakBokris
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: