Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(concurrency): applying blocks concurrently can lead to unexpected errors #700

Merged
merged 17 commits into from
Apr 21, 2024
Merged

fix(concurrency): applying blocks concurrently can lead to unexpected errors #700

merged 17 commits into from
Apr 21, 2024

Commits on Apr 16, 2024

  1. execute uses pubkey instead of sequencer object

    @mtsitrin
    mtsitrin committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a66eb8c View commit details
    Browse the repository at this point in the history

  2. added syncMutex

    @mtsitrin
    mtsitrin committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    663ae77 View commit details
    Browse the repository at this point in the history

  3. fixed goroutine leak in case of closed subscription

    @mtsitrin
    mtsitrin committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d388822 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. rename block execution -> execute block

    @danwt
    danwt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c276b07 View commit details
    Browse the repository at this point in the history

  2. add comments

    @danwt
    danwt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    dd0a575 View commit details
    Browse the repository at this point in the history

  3. simplify wording

    @danwt
    danwt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    45cecf0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into mtsitrin/658-applying-blocks-concurrently-ca… 

    …n-lead-to-unexpected-errors
    @mtsitrin
    mtsitrin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    69521b3 View commit details
    Browse the repository at this point in the history

  5. moved locking post data fetching

    @mtsitrin
    mtsitrin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6433abc View commit details
    Browse the repository at this point in the history

  6. locked on attemptApplyCachedBlocks

    @mtsitrin
    mtsitrin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    481c705 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'main' into mtsitrin/658-applying-blocks-concurrently-ca… 

    …n-lead-to-unexpected-errors
    @mtsitrin
    mtsitrin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d343dca View commit details
    Browse the repository at this point in the history

  2. fixed compilation

    @mtsitrin
    mtsitrin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3fd1aa5 View commit details
    Browse the repository at this point in the history

  3. applying all cached blocks on gossiped block 

    pruning cache only on synctarget
    @mtsitrin
    mtsitrin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8ad28b5 View commit details
    Browse the repository at this point in the history

  4. calling applycache on correct heihgt only

    @mtsitrin
    mtsitrin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e234d07 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into mtsitrin/658-applying-blocks-concurrently-ca… 

    …n-lead-to-unexpected-errors
    @mtsitrin
    mtsitrin committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0a43157 View commit details
    Browse the repository at this point in the history

  2. unified the block cache

    @mtsitrin
    mtsitrin committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8c9a1ac View commit details
    Browse the repository at this point in the history

  3. renamed m.retrieverMutex. add lock on cache pruning

    @mtsitrin
    mtsitrin committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a329116 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. cleaning cache on apply instead of pruning

    @mtsitrin
    mtsitrin committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    086e320 View commit details
    Browse the repository at this point in the history