Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(da): full-node get the da fetch configuration from hub and not config #719

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Apr 22, 2024

PR Standards

This is a code refactor to avoid using namespace id param from configuration in full-nodes, since it is not relevant and it can lead to potential config issues, and the important is the namespace used by sequencer when posting batches.

Opening a pull request should be able to meet the following requirements


Close #718

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Apr 22, 2024
@srene srene requested a review from a team as a code owner April 22, 2024 10:31
@srene srene changed the title refactor(da): full-node gets namespace from daPath (batch info) instead of config for retrieval and avail check using celestia refactor(da): full-node gets namespace id from daPath (batch info) instead of da config for retrieval and avail check using celestia Apr 22, 2024
@omritoptix omritoptix changed the title refactor(da): full-node gets namespace id from daPath (batch info) instead of da config for retrieval and avail check using celestia fix(da): full-node get the da fetch configuration from hub and not config Apr 22, 2024
da/celestia/celestia.go Outdated Show resolved Hide resolved
@omritoptix omritoptix merged commit 6bc6c97 into main Apr 25, 2024
4 checks passed
@omritoptix omritoptix deleted the srene/718-namespace-from-dapath-fullnode branch April 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full-node should use namespace id obtained from batch, and not from config
3 participants