Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(ci): Auto changelog with PR title instead #734

Merged
merged 11 commits into from
May 6, 2024
Merged

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner April 29, 2024 03:01
@mtsitrin
Copy link
Contributor

mtsitrin commented May 5, 2024

@hoangdv2429 can we have the changelog update created as separate PR?
currently, existing PRs got pushed with changelog updates, which makes mess and conflicts.

IMO it should be that when main has new commit, a new PR will be created with changelog update.
and not pushing this to existing open PRs

@hoangdv2429
Copy link
Contributor Author

I have one pr open do exactly that in rollapp-evm. I want to make sure it work first in rollapp-evm and then backport it

@mtsitrin mtsitrin merged commit cd66dfd into main May 6, 2024
2 checks passed
@mtsitrin mtsitrin deleted the feat/auto_changelog branch May 6, 2024 06:19
@hoangdv2429 hoangdv2429 restored the feat/auto_changelog branch May 9, 2024 08:47
omritoptix pushed a commit that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants