Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync) initial block height when getting state #764

Closed
wants to merge 5 commits into from
Closed

fix(sync) initial block height when getting state #764

wants to merge 5 commits into from

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented May 1, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

Close #761

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this May 1, 2024
@zale144 zale144 requested a review from a team as a code owner May 1, 2024 23:39
danwt
danwt requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we just always get current_height + 1?

@mtsitrin mtsitrin self-requested a review May 2, 2024 12:21
@danwt
Copy link
Contributor

danwt commented May 2, 2024

I think this clashes with #763 pr

@danwt
Copy link
Contributor

danwt commented May 2, 2024

mind if I close this just to simplify our pr list

@danwt danwt closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt requested changes

@mtsitrin mtsitrin Awaiting requested review from mtsitrin

Assignees

@zale144 zale144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: GetHeightState for height = 0
3 participants
@zale144 @danwt @mtsitrin