Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(da): SubmitBatchV2 method for interchain DA #929

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Jun 26, 2024

Part of #930

This PR contains changes with respect to the generalized DA specification. This is the first part of the implementation.

Changelog:

  • Added interchain to the da registry [1]
  • Added DAClientV2 interface [2]
  • Added BatchRetrieverV2 [3]
  • Added V2 for ResultRetrieveBatch [4], ResultSubmitBatch [5]
  • Added da.Path [6]
  • Added the interchain DA client [7]
  • Interchain DA client config and tests [8]
  • Init for the interchain DA client [9]
  • SubmitBatchV2 for the interchain DA client [10]

For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests <-- is not needed in this PR
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch added the C:da DA related label Jun 26, 2024
@keruch keruch self-assigned this Jun 26, 2024
@keruch keruch changed the title Kirill/interchain da feat(da): scaffolding intechain DA provider Jun 26, 2024
@keruch keruch changed the base branch from main to kirill/interchain-da-proto June 27, 2024 19:03
@keruch keruch force-pushed the kirill/interchain-da branch 3 times, most recently from c1f6b88 to de0a32a Compare July 1, 2024 19:06
@keruch keruch changed the title feat(da): scaffolding intechain DA provider feat(da): SubmitBatchV2 method for interchain DA Jul 1, 2024
@keruch keruch requested review from srene and spoo-bar July 2, 2024 09:09
@keruch keruch marked this pull request as ready for review July 2, 2024 09:09
@keruch keruch requested a review from a team as a code owner July 2, 2024 09:09
da/interchain/config.go Dismissed Show dismissed Hide dismissed
da/interchain/chain_client.go Fixed Show fixed Hide fixed
@keruch keruch force-pushed the kirill/interchain-da-proto branch from 6768fe1 to 9c81c58 Compare July 3, 2024 15:21
@keruch keruch force-pushed the kirill/interchain-da-proto branch from 9c81c58 to 867fbbc Compare July 3, 2024 15:34
@keruch keruch mentioned this pull request Jul 4, 2024
12 tasks
Base automatically changed from kirill/interchain-da-proto to main July 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant